Report both system.disk.io_time (wall clock) & system.disk.operation_time #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
disk-time
branch
from
9a6bd85 to
81b8f04
Compare
james-bebbington
commented
Oct 1, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper_windows.go
Show resolved
Hide resolved
james-bebbington
changed the title
james-bebbington
force-pushed
the
disk-time
branch
3 times, most recently
from
b3e0037 to
9832a44
Compare
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
==========================================
- Coverage 91.46% 91.38% -0.08%
==========================================
Files 284 282 -2
Lines 16739 16676 -63
==========================================
- Hits 15310 15240 -70
- Misses 1000 1006 +6
- Partials 429 430 +1
Continue to review full report at Codecov.
|
bogdandrutu
previously approved these changes
Oct 1, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper_windows.go
Show resolved
Hide resolved
asuresh4
reviewed
Oct 5, 2020
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_metadata.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/diskscraper/disk_scraper_windows.go
Show resolved
Hide resolved
james-bebbington
force-pushed
the
disk-time
branch
2 times, most recently
from
c438362 to
935b37e
Compare
james-bebbington
force-pushed
the
disk-time
branch
from
935b37e to
24728f5
Compare
james-bebbington
changed the title
asuresh4
approved these changes
Oct 9, 2020
# Conflicts: # CHANGELOG.md
|
@bogdandrutu you reviewed this initially, do you have any other comments or good to merge? |
bogdandrutu
approved these changes
Oct 19, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1887) Bumps [boto3](https://github.com/boto/boto3) from 1.24.52 to 1.24.53. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.52...1.24.53) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report both types of disk time metrics on both Linux & Windows as per this comment thread: open-telemetry/opentelemetry-specification#937 (comment)
Breaking Change:
system.disk.timemetric renamed tosystem.disk.operation_time